feat(ingest/transform): extend ownership transformer to other entities

[anshbansal]

• extend pattern cleanup transformer to other entities
• future suggestion - might be good to auto generate list of entities that have ownership aspects. Will allow us to extend all ownership transformers very easily. Added some common entities for now

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[github-actions]

Hello @anshbansal 😄

Thank you so much for opening a pull request!

You can check out your contributor card and see all your past stats here!

[skrydal]

I think overall we should refactor our transformers, it's strange that we are having more generic transformer OwnershipTransformer inheriting from less generic one DatasetTransformer - it will of course work, but I think we should consider, not as a part of this PR, to refactor all our transformers and allow for other entities to be transformed (there are other requests related to, for example, tagging other entities than datasets).
We really need at least one test case for the new transformer though.
Also shouldn't we add new transformer to the list of transformers in setup.py?

[anshbansal]

@skrydal There is no new transformer. It's name has not been changed. It is the same transformer so no need to change in setup.py

[skrydal]

@skrydal There is no new transformer. It's name has not been changed. It is the same transformer so no need to change in setup.py

You are right, sorry. So the essence of the change here is that AddDatasetOwnership now will be adding ownership to other entities too. Won't it be misleading - both in terms of name, as well as changing the behavior of an existing transformer - users might not expect that. Why don't we create a generalized AddOwnershipTransformer?

Also, I understand that in the test case if we kept the DataJob we would have 2 more aspects in the output - first that of DataJobInfo and second Ownership (for dataJob this time). Wouldn't it exemplify the nature of the change introduced better?

Taken care of comments

[skrydal]

LGTM

[aviv-julienjehannet]

Thank you so muck to extend this transformer! But, isn't there any updated markdown files to be changed to document this improvement?