fix(ingest/azure_ad): support v2 (Entra ID) endpoints #11749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
wfrced
commented
Oct 29, 2024
| } | ||
| if self.config.endpoint_version == "v2": | ||
| self.token_data["scope"] = "https://graph.microsoft.com/.default" |
There was a problem hiding this comment.
This is potentially breaking - I've excluded scope by default because it doesn't seem like it is used by v1 API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Azure AD ingestion source to fetch data from v2 endpoints (Entra ID), instead of failing with 400 error due to
resourcefield not being supported by v2 API.I've decided to add an optional field
endpoint_version, and send eitherresourceorscopetoken field depending on its value. Could be a boolean (or be extracted fromauthority/token_url), but this is simpler and clearer.Apologies in advance for linking to stackoverflow, but I couldn't find a better resource on Microsoft's side.
Checklist