feat(ingest/powerbi): improve reporting around m-query parser #11763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Oct 31, 2024
Comment on lines
1092
to
1100
| if ( | ||
| len(data_access_tokens) >= 13 | ||
| ): # Explicit catalog name is set in Database argument | ||
| return tree_function.strip_char(data_access_tokens[9]) | ||
|
|
||
| if ( | ||
| len(data_access_tokens) >= 6 and data_access_tokens[4] == "Catalog" | ||
| ): # use Catalog name is database | ||
| return tree_function.strip_char(data_access_tokens[5]) |
There was a problem hiding this comment.
This looks super magical, could you add some example lists of tokens to explain what cases are being handled?
hsheth2
force-pushed
the
powerbi-m-query
branch
from
3b5fc52
to
45cb289
Compare
hsheth2
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates changes from feat(ingestion/powerbi): DatabricksMultiCloud native query support #11756Checklist