Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(views): fix environment filter for views #11771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(views): fix environment filter for views #11771

wants to merge 1 commit into from
+83 −1

Conversation

RyanHolstien
Copy link
Collaborator

Fixes the environment filter for views by expanding origin to include env fields on entities that use env instead. Also adds the reverse expansion.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien self-assigned this Oct 31, 2024
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker Awaiting requested review from david-leifker

@chriscollins3456 chriscollins3456 Awaiting requested review from chriscollins3456

At least 1 approving review is required to merge this pull request.

Assignees

@RyanHolstien RyanHolstien

Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RyanHolstien