-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(ingest): test with python 3.11 #6485
Conversation
Unit Test Results (metadata ingestion) 4 files - 4 4 suites - 4 28m 6s ⏱️ - 29m 36s Results for commit 8cd620c. ± Comparison against base commit b7c0373. This pull request skips 1 test.
|
Now blocked on googleapis/python-bigquery-sqlalchemy#543 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green
Looks all tests are failing now. |
Looks like we're somehow pinning pyarrow to an old version, which doesn't have a pre-built binary for python 3.11. Ideally we should loosen our deps, but we can also add the necessary requirements so that it can build from source for 3.11 instead. |
Blocked because of feast-dev/feast#3510 |
No longer blocked on feast. Now we're blocked on cloudera/python-sasl#30 (we actually use sasl3 and not sasl but they face the same issue). We only depend on sasl3 from acryl-pyhive, so we probably could upgrade it to use pure-sasl instead. There seems to be an effort around that already dropbox/PyHive#454. |
Just need to merge acryldata/PyHive#7 and update here, and then we should be good to go. |
I made a couple of contributions to PyHive which were accepted and released in 0.7.1.dev0. You are requested to test with the dev version and report any bugs in the PyHive GitHub repository before 0.7.1 is released in a month or so.
|
Related to acryldata/PyHive@c6085e0 in service of datahub-project#6485.
Looks like there's two errors now:
|
|
Unblocked now that #9008 was merged |
One more thing here: To be compatible with Python 3.11, we need to be on pyspark 3.4+ (see apache/spark#38987) However, pydeequ still depends on pyspark 3.3 right now (awslabs/python-deequ#168). The underlying deequ issue was recently fixed (awslabs/deequ#505), so pydeequ will hopefully get updated quickly. |
Moving the StrEnum changes to #11270 |
Closing in favor of #11280 |
Checklist