Initial annex support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mih
force-pushed
the
init
branch
2 times, most recently
from
be77127
to
2f0f874
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 27 31 +4
Lines 882 1111 +229
Branches 54 73 +19
==========================================
+ Hits 882 1111 +229 ☔ View full report in Codecov by Sentry. |
mih
force-pushed
the
init
branch
4 times, most recently
from
25b04d9
to
d3f5b18
Compare
Low-level helper to execute git-annex command that support `--json` and `--json-error-messages`. This initial implementation does not (yet) support input iterables.
mih
force-pushed
the
init
branch
3 times, most recently
from
7dc5291
to
fcd1237
Compare
`Repo` and `Worktree` received dedicated, optional support for annexes, and their initialization. The concept is is substantially different from that implemented in legacy DataLad. There, an `AnnexRepo` class was derived from a `GitRepo` class and extended and overwrote individual methods, forming a relatively high-level API. Here, any `Repo` or `Worktree` can have an optional annex. All operations related to that annex are implemented in dedicated handlers that are fully independent of a `Repo` or `Worktree` instance. The aim is to reduce the complex interdependencies that cripple the validity and robustness of the legacy implementations. Git is used more "directly", even in git-annex repositories and git-annex is used more directly, and agnostic of the context and demands of high-level operations. This has important consequences. For example, a method like the legacy `AnnexRepo.save()` cannot exist, because there is no `GitRepo.save` that it can override and "do the right thing" for a git-annex repository. This is acceptable here, because the API provided in this module is not targeting the level of compound/convenience operations like `save()` that aim to alleviate a developer's required expertise. Instead, the aim here is to provide primitives that can be used in a higher-level (possibly function-based) API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the seamless continuation of #19 -- just to set an arbitrary merge cutoff.