Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change include_descriptors default to None and better handling of label names #53

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

maclandrol
Copy link
Member

Changelogs

  • include_descriptors is not disabled by default and label_names does not need to be provided to get eval loss.

Checklist:

  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

See #49

@maclandrol
Copy link
Member Author

ping @Anri-Lombard

@Anri-Lombard
Copy link
Contributor

Thank you for the quick move @maclandrol! I briefly made include_descriptors False and it still did not record the validation loss, but I see you made a few logic changes that I'll need to download locally and run; I'll do this in 60-ish minutes 👍

@Anri-Lombard
Copy link
Contributor

Screenshot 2024-07-30 at 13 38 15

@maclandrol I can confirm this worked! 🙂

@maclandrol maclandrol merged commit f28b97a into main Jul 30, 2024
3 checks passed
@maclandrol maclandrol deleted the cli-eval branch July 30, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants