Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 404 page layout #595

Merged
merged 8 commits into from
Jul 6, 2023
Merged

New 404 page layout #595

merged 8 commits into from
Jul 6, 2023

Conversation

pcnorth
Copy link
Contributor

@pcnorth pcnorth commented Jul 5, 2023

This is the new 404 page content

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

Signed-off-by: pcnorth <120174435+pcnorth@users.noreply.github.com>
Signed-off-by: pcnorth <120174435+pcnorth@users.noreply.github.com>
layouts/404.html Show resolved Hide resolved
layouts/404.html Outdated Show resolved Hide resolved
pcnorth and others added 2 commits July 5, 2023 13:56
Co-authored-by: Jon Geater <jon.geater@gmail.com>
Signed-off-by: Phil North <120174435+pcnorth@users.noreply.github.com>
Co-authored-by: Jon Geater <jon.geater@gmail.com>
Signed-off-by: Phil North <120174435+pcnorth@users.noreply.github.com>
@pcnorth pcnorth requested a review from JAG-UK July 5, 2023 13:00
…uch big black text and unbalanced the page

Signed-off-by: pcnorth <120174435+pcnorth@users.noreply.github.com>
Signed-off-by: pcnorth <120174435+pcnorth@users.noreply.github.com>
Copy link
Contributor Author

@pcnorth pcnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made. I moved the additional text added to the heading into a new paragraph because it overpowered the visual effect of the page and made it unbalanced.

…ragraph and into one of the YAML examples

Signed-off-by: pcnorth <120174435+pcnorth@users.noreply.github.com>
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks

@@ -307,7 +306,9 @@ To view your Asset, click on the Asset row. You will see the detailed history of
The `ASSETS_LIST` action can be filtered using identifying attributes (`attrs`) to view the details of a specific Asset.
```yaml
---
steps:
steps:An Asset can be anything: a connected machine, a shipping container, or even a data set. It can be any physical or digital object with an associated name, description, and attributes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change in here? Doesn't seem to be anything to do with 404?

@pcnorth pcnorth merged commit be95f04 into main Jul 6, 2023
1 check passed
@pcnorth pcnorth deleted the new_404 branch July 6, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants