fix(macos): Enable template mode for menu bar tray icon - #175
Merged
Conversation
The tray PNG was loaded as a literal white bitmap, so it stayed white when other menu bar icons adapted to light and dark backgrounds. Set NSImage template mode via tray-icon's builder API so macOS tints it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS, the Datum tray icon stayed white while neighboring menu bar icons switched between light and dark tints. We already ship a monochrome PNG named for template use, but never told AppKit to treat it as one. Without
NSImage.isTemplate, the system draws the pixels literally instead of adapting them to the menu bar background.This sets
with_icon_as_template(true)on theTrayIconBuilderfor macOS builds. macOS then uses the icon's alpha channel as a mask and picks the right foreground color for light menu bars, dark menu bars, and highlighted states. No second asset or appearance polling required.Test plan