Skip to content

Commit

Permalink
Make the comment shorter
Browse files Browse the repository at this point in the history
  • Loading branch information
lebr0nli committed Jul 25, 2023
1 parent 9749fea commit fbc2a47
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions lib/one_gadget/fetchers/objdump.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,8 @@ def extra_options=(options)
# @param [Integer] stop The end address.
# @return [String] The CLI command to be executed.
def command(start: nil, stop: nil)
# --dwarf-start=0 is to make sure `suppress_bfd_header` is true to eliminate the information that includes the file path:
# https://github.com/CyberGrandChallenge/binutils/blob/ccdf202188a21ff0f0c2abfdb0814c244c251436/binutils/objdump.c#L3628-L3632
# https://github.com/CyberGrandChallenge/binutils/blob/ccdf202188a21ff0f0c2abfdb0814c244c251436/binutils/objdump.c#L3206-L3208
# See also: #204
# --dwarf-start=0 is to make sure `suppress_bfd_header` is true to eliminate the file path in the output, see
# issue #204 for more details.
# Note: We might need to update this when the objdump act differently in the future.
cmd = [bin, '--dwarf-start=0', '--no-show-raw-insn', '-w', '-d', *@options, @file]
cmd.push('--start-address', start) if start
Expand Down

0 comments on commit fbc2a47

Please sign in to comment.