Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libE57Format to v 3.1.1 #55

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Upgrade libE57Format to v 3.1.1 #55

merged 5 commits into from
Mar 12, 2024

Conversation

dancergraham
Copy link
Collaborator

Update to a more recent version of the underlying library

@dancergraham
Copy link
Collaborator Author

for the moment I have removed the variable min max values to get this to compile. I would like to put them back to avoid breaking anybody's code. Ultimately I would like to remove them or put them in a separate namespace to clean up the interface a bit

@dancergraham
Copy link
Collaborator Author

I'm currently stuck with the extensionsLookupPrefix definition (line 501 in libd57_wrapper.cpp) possibly because it is now overloaded - I may need to use the following :

https://pybind11.readthedocs.io/en/stable/classes.html#overloaded-methods

@dancergraham
Copy link
Collaborator Author

Merging like this for now. We still need to add new features and remove outdated ones from the libe57 namespace.

@dancergraham dancergraham merged commit 4138384 into master Mar 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant