Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2_gemometry_msgs as a dep for vn_sensor_msgs; try/catch readGpsCompassBaseline #59

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

jfinken
Copy link

@jfinken jfinken commented Apr 12, 2021

Changes:

  • Add tf2_gemometry_msgs as a dep for vn_sensor_msgs
  • try/catch around readGpsCompassBaseline()

Addressing:

@dawonn
Copy link
Owner

dawonn commented Apr 12, 2021

Thank you very much for the PR, it's incredibly appreciated!

@dawonn dawonn merged commit cade64c into dawonn:ros2 Apr 12, 2021
@dawonn
Copy link
Owner

dawonn commented Apr 12, 2021

I'm guessing that the get GPS baseline function should only be called if it's a VN300. It would be super cool if you could wrap that in an if statement that checks that the device is a VN300, that way VN 100 and 200 users aren't seeing error messages that don't pertain to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants