Bug fix: Apply metric_time filters to time spine when needed
#1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
changed the title
courtneyholcomb
changed the title
metric_time filters to time spine when needed
courtneyholcomb
force-pushed
the
court/ts-filter3
branch
from
f658c16
to
1a060b8
Compare
And also simplify / reorganized displayed properties for the node.
courtneyholcomb
force-pushed
the
court/ts-filter3
branch
from
1a060b8
to
f4a673c
Compare
courtneyholcomb
force-pushed
the
court/ts-filter3
branch
from
f4a673c
to
692a082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug where, if you query a join_to_timespine metric with a metric_time filter that is not applied in the group by, you will end up with more rows than expected.
To fix that, we need to apply any metric_time filters to the time spine table before joining that table to the aggregated measure. This needs to happen before the join instead of after because after the join we may not have access to metric_time at the grain needed for the filter. This implements that behavior.
I recommend reviewing by commit.