-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish workflow #25
Open
s-weigand
wants to merge
8
commits into
dderevjanik:master
Choose a base branch
from
s-weigand:add-publish-workflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+12,702
−2,571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-weigand
force-pushed
the
add-publish-workflow
branch
from
October 15, 2020 15:27
b0a1651
to
f2dd3b6
Compare
Rebased the PR to fix the conflict ^^ |
s-weigand
force-pushed
the
add-publish-workflow
branch
from
March 26, 2021 21:33
f2dd3b6
to
35b8b77
Compare
Merged
changed release to not be a draft
and removed it from the workflow see web-ext 5 release notes: https://github.com/mozilla/web-ext/releases/tag/5.0.0
Moved this commit up to easier solve issues with conflicts in package-lock.json
s-weigand
force-pushed
the
add-publish-workflow
branch
from
April 5, 2021 11:18
35b8b77
to
0b754d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 16.85% 16.80% -0.05%
==========================================
Files 19 19
Lines 362 363 +1
Branches 47 47
==========================================
Hits 61 61
- Misses 299 300 +1
Partials 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #24 I added workflow to make a release when a tag is pushed.
Features:
v
(i.e.v1.23
), the extension gets published on the chrome and firefox store.For this to work you need to set the proper secrets for the Google API and the AMO API. In my extension I found that you also need to provide the extension IDs that were given when published before, so it updates the addon instead of publishing a new one.
EXTENSION_ID
=hoccpcefjcgnabbmojbfoflggkecmpgd
Not needed anymore withWEB_EXT_ID
={dd10a870-27c8-4b74-bfd4-0f767fe68770}
web-ext^=5.0.0