multi: Show PowHash on blocks view page for DCP0011 #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
ukane-philemon
commented
Jul 18, 2023
Comment on lines
+5840
to
+5844
| header, err := pgb.Client.GetBlockHeader(pgb.ctx, blockChainHash) | ||
| if err != nil { | ||
| log.Errorf("failed to fetch header for block hash %s: %v", data.Hash, err) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This looks a bit expensive?
There was a problem hiding this comment.
Ideally PowHash would be added to chainjson.GetBlockVerboseResult (a dcrd change). We get this just above, at the start of this method. AFAIK, we can only get this at present by hashing the block header.
There was a problem hiding this comment.
Would require: decred/dcrd#3154
chappjc
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Verified working. Will follow up if decred/dcrd#3154 becomes available so we can skip the request for the raw header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1965.