jsonrpc: Stop background (more) rescans gracefully #2434
+39
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
changed the title
This ensures that the context of in-flight RPC requests is cancelled when the dcrwallet process context is cancelled.
Use the server waitgroup to ensure background rescans can return on their own terms rather than being forcefully terminated early. This is still not an ideal situation because in the case where the server/wallet is being shut down, RescanFromHeight will return with an "rpc connection closed" error (or similar) rather than returning because its provided context was cancelled. However, that is a notable improvement over the existing situation which could result in an unhandled panic.
Using the server context instead of context.Background means that the long-lived rescan funcs are able to exit properly when the server is shutdown and its context is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the server waitgroup to ensure background rescans can return on their own terms rather than being forcefully terminated early.
Using the server context instead of context.Background means that the long-lived rescan funcs are able to exit properly when the server is shutdown and its context is closed.
Based on #2435