-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate the Prerecorded Object to Hide Internal Details #103
Encapsulate the Prerecorded Object to Hide Internal Details #103
Conversation
990bc96
to
4d28e39
Compare
EDIT: updated description to include Issue #105 being addressed by this PR |
Until these get merged, here is a better looking diff to track the changes between branches: dvonthenen/deepgram-go-sdk@dv/live-streaming-object-definition...dvonthenen:deepgram-go-sdk:dv/prerecorded-object-definition |
I get an error when I run the project main.go file on this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check the examples/projects/main.go? I'm getting an error when I run that file on this branch
discussed in slack... I didn't really treat the at that point, I was just using that example as testing grounds for various APIs. |
The base branch was changed.
4d28e39
to
94e383c
Compare
94e383c
to
9e15ccf
Compare
I deleted the |
Proposed changes
NOTE: This depends on #86, #87, #88 and is targeted to
go-sdk-v1
release. Will rebase when dependent PRs are merged. The diff in this PR will look pretty nasty until subsequent depend PRs are merged first. Until these get merged, here is a better looking diff to track the changes between branches: dvonthenen/deepgram-go-sdk@dv/live-streaming-object-definition...dvonthenen:deepgram-go-sdk:dv/prerecorded-object-definitionAddresses #92, #102, and #105.
Implements more of an object-oriented approach to handling the prerecorded struct. This change implements the following:
context
to be passed into the Live Client creation. This is to facilitate:Cancel
for any REST callexamples/prerecorded
has been updated to show how to use the client.Types of changes
What types of changes does your code introduce to the community Go SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
PR #86 handled the restructure of the project. This is the first PR to start refactoring and improving individual components in this new restructure. This PR handles just the Live Client and Live Client only. I am trying to reduce the amount of code change in this PR and each component will be handled one at a time.
Will squash the commits after the review is completed.