Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add overlap output in feature_to_block #208

Merged
merged 2 commits into from
Sep 19, 2024
Merged

add overlap output in feature_to_block #208

merged 2 commits into from
Sep 19, 2024

Conversation

AsymmetryChou
Copy link
Collaborator

enable feature_to_block to construct overlap matrix block.

@AsymmetryChou
Copy link
Collaborator Author

画能带时直接通过了HR2HK类完成了从feature到HK的变换，HR block封装在里面，每个HR_block完成赋值之后乘上相位累加，但HR_block在for循环中每次都被释放掉了，还是写一个独立的feature2HR比较方便些

@floatingCatty
Copy link
Member

画能带时直接通过了HR2HK类完成了从feature到HK的变换，HR block封装在里面，每个HR_block完成赋值之后乘上相位累加，但HR_block在for循环中每次都被释放掉了，还是写一个独立的feature2HR比较方便些

这个功能好像就是feature2block?

@AsymmetryChou
Copy link
Collaborator Author

这个功能好像就是feature2block?
原本的feature2block里面应该只有HR block，没有SR block。这里增加的是overlap呢

@QG-phy QG-phy merged commit 6c38085 into deepmodeling:main Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floatingCatty floatingCatty floatingCatty approved these changes

@QG-phy QG-phy QG-phy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsymmetryChou @floatingCatty @QG-phy