Skip to content

docs: define GROMACS model deviation arguments - #1959

Open
njzjz-bot wants to merge 2 commits into
masterfrom
docs/issue-771-gromacs-arginfo
Open

docs: define GROMACS model deviation arguments#1959
njzjz-bot wants to merge 2 commits into
masterfrom
docs/issue-771-gromacs-arginfo

Conversation

@njzjz-bot

Copy link
Copy Markdown
Collaborator

Summary

  • replace the empty GROMACS model-deviation variant with a strict schema;
  • document per-iteration GROMACS fields, required input files, and trajectory-processing settings;
  • include the common selection/cleanup controls used after GROMACS exploration;
  • add strict validation coverage for all fields consumed by the current maker and runner.

Tests

  • /tmp/dpgen-test-env/bin/python -m unittest tests.test_check_examples -v
  • ruff check dpgen/generator/arginfo.py tests/test_check_examples.py
  • ruff format --check dpgen/generator/arginfo.py tests/test_check_examples.py

Fixes #771

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 849cf3b4-eb0f-4c82-9b83-d1d82eac68d8

📥 Commits

Reviewing files that changed from the base of the PR and between d5ce577 and e267a05.

📒 Files selected for processing (4)
  • dpgen/generator/arginfo.py
  • dpgen/generator/run.py
  • tests/generator/test_gromacs_engine.py
  • tests/test_check_examples.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.84%. Comparing base (d5ce577) to head (e267a05).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1959      +/-   ##
==========================================
+ Coverage   49.80%   49.84%   +0.03%     
==========================================
  Files          83       83              
  Lines       14986    14997      +11     
==========================================
+ Hits         7464     7475      +11     
  Misses       7522     7522              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review C

I found no blocking correctness, regression, security, or API issue in this change. CI/check evidence was considered alongside the full patch and relevant surrounding implementation. A formal APPROVE state cannot be submitted because the active njzjz-bot account is the PR author; GitHub self-review rules permit only a COMMENT review here.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review B

No blocking findings. I reviewed the full diff, relevant surrounding behavior, tests, and current check status. GitHub does not permit njzjz-bot to APPROVE or REQUEST_CHANGES on its own pull request, so this review is recorded as COMMENT only.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review A

A blocking runtime/schema mismatch is attached inline. GitHub does not permit njzjz-bot to approve or request changes on its own PR, so this COMMENT review records the result as changes needed; no formal review state is claimed.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Comment thread dpgen/generator/arginfo.py
Coding-Agent: Codex
Codex-Version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review B

Re-reviewed the current head, including GROMACS argument metadata, input staging semantics, generated MDP handling, and successful CI. I found no blocking issue. No further changes are required from this review.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review C

No changes remain from this independent pass. GitHub does not allow njzjz-bot to formally approve its own PR, so this review is submitted as COMMENT rather than APPROVE.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review A

No remaining correctness issues found at e267a05. I checked the GROMACS schema, staged input-file derivation for default and custom deffnm values, regression coverage, and passing CI. Because this PR is authored by njzjz-bot, GitHub does not permit this account to approve its own PR; this COMMENT means no changes remain from independent re-review A.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation] add model_devi Variant gromacs

1 participant