Skip to content

Commit

Permalink
build!: Stop building arm64 (#188)
Browse files Browse the repository at this point in the history
The reason for building arm64 no longer applies as `sshuttle` now works on Apple Silicon even when using the x86 image.

BREAKING CHANGE: No longer building the arm64 image
  • Loading branch information
RothAndrew authored Feb 7, 2024
1 parent ee801c6 commit c22d01e
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 10 deletions.
5 changes: 3 additions & 2 deletions .github/actions/test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ runs:
tags: |
type=raw,value=${{ github.ref_name }}
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
# QEMU is only required for cross-platform builds
# - name: Set up QEMU
# uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/tag-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ jobs:
matrix:
platform:
- linux/amd64
- linux/arm64/v8
# We used to build for arm64, and we can again in the future by simply uncommenting this line in each of the "matrix" blocks
# - linux/arm64/v8
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -31,8 +32,9 @@ jobs:
tags: |
type=raw,value=${{ github.ref_name }}
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
# QEMU is only required for cross-platform builds
# - name: Set up QEMU
# uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/test-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ jobs:
matrix:
platform:
- linux/amd64
- linux/arm64/v8
# We used to build for arm64, and we can again in the future by simply uncommenting this line in each of the "matrix" blocks
# - linux/arm64/v8
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/trigger-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ jobs:
matrix:
platform:
- linux/amd64
- linux/arm64/v8
# We used to build for arm64, and we can again in the future by simply uncommenting this line in each of the "matrix" blocks
# - linux/arm64/v8
steps:
- name: skip-tests-if-pull-request-event
# noinspection YAMLSchemaValidation
Expand All @@ -72,7 +73,7 @@ jobs:
matrix:
platform:
- linux/amd64
- linux/arm64/v8
# - linux/arm64/v8
outputs:
# return 'true' if any files in the PR are not exempt
not-exempt: ${{ steps.changed-files.outputs.not-exempt_any_modified }}
Expand Down Expand Up @@ -106,7 +107,7 @@ jobs:
matrix:
platform:
- linux/amd64
- linux/arm64/v8
# - linux/arm64/v8
steps:
- name: skip-tests-if-merge-group-event-and-exemption-criteria-met
uses: defenseunicorns/delivery-github-actions-workflows/.github/actions/report-status-context@main
Expand All @@ -126,7 +127,7 @@ jobs:
matrix:
platform:
- linux/amd64
- linux/arm64/v8
# - linux/arm64/v8
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand Down

0 comments on commit c22d01e

Please sign in to comment.