Add github to check and automatically update the Zarf Injector component upon renovate execution (or other PR) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntwkninja
reviewed
Oct 6, 2024
ntwkninja
previously approved these changes
Oct 6, 2024
ntwkninja
reviewed
Oct 6, 2024
|
Okay, I think I fixed the action logic. I moved the original logic for release into the injector update, so it only triggers on push to main where the zarf.yaml or zarf-config.yaml changes and then the release action triggers on completion of that job. This should address the security concerns and finalize the feature with intended functionality. |
ntwkninja
approved these changes
Oct 6, 2024
manually updating shasums (defenseunicorns#252) attempt at automating the toml change attempt at automating the toml change 2 attempt at automating the toml change 3 attempt at automating the toml change 4 attempt at automating the toml change 5 chore(deps): update all dependencies Update Zarf injector version and shasums from zarf-config.toml chore(deps): update actions/checkout action to v4 attempt at automating the toml change 6 turn publish back on Update Zarf injector version and shasums from zarf-config.toml add check to action if changes are made to avoid commit issues removed excess changes to renovate file removed excess changes to renovate file 2 updated to use Github env variables due to action warning deprecating use of set-output add feature based on Gabe's feedback to checkout the right zarf version to avoid injector to version mismatch add feature based on Gabe's feedback to checkout the right zarf version to avoid injector to version mismatch but fixed a stupid mistake add feature based on Gabe's feedback to checkout the right zarf version to avoid injector to version mismatch but fixed a stupid mistake v2 add feature based on Gabe's feedback to checkout the right zarf version to avoid injector to version mismatch but fixed a stupid mistake v3 add feature based on Gabe's feedback to checkout the right zarf version to avoid injector to version mismatch but fixed a stupid mistake v4 remove PR logic from on PR and instead limit it to on push to main fix release to run after injector fix and add logic to injector to run on changes to the zarf.yaml or zarf-config.yaml removed stale comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was messing with renovate and other tooling to see if I could get the Zarf injector to update automatically. Since the file change is in the zarf-config.toml file upstream and not in the release itself or tagging, there's nothing I think renovate can do. So, I think a Github action to pull the file and check is still a decent option. I forked the repo and tested it by changing the values and watching the action change it back on the push to main.