-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template)!: introducing variables and sensitive configuration #672
feat(template)!: introducing variables and sensitive configuration #672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a fan of this direction - called out a few items we may want to think about but otherwise this meets our requirements.
I looked for any concerns or risks present with the nested brace replacement and did not find any issues.
A lot of commonality between our approaches made this an easy review.
Additionally can we update the go mod/sum files when preparing for next review? |
When you say update - is there a particular package you were looking at or just like a |
So I spent a little more time on this then I was initially planning and did some refactor of the internal/template package + the command. I was running into some issues when testing the cmd where the flags getting set were persisting across runs - which is not ideal. I refactored this so that we don't have external to the command flags (which sort of runs counter to what we do in all our other cmds, but I've seen this pattern in other cobra cli usage and tbh I like it better, seems to reduce side effects when testing.) |
…configuration-and-prevent-templating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor inconsistency in the help command. quick modification and re-generation of the cli doc and I'm good!
Description
Sample implementation for sensitive and non-sensitive configuration data to support templating
Related Issue
Relates to #641
Type of change
Checklist before merging