-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes)!: wait logic kubernetes version support #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oth-create-resources-and-resources-in-the-kubernetes-spec
…oth-create-resources-and-resources-in-the-kubernetes-spec
…-in-the-kubernetes-spec' into 229-wait-logic-kubernetes-version-support
mildwonkey
reviewed
Oct 9, 2024
brandtkeller
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciative of native existence support. Can we include updates the go mod/sum as I imagine there are items we can remove from our dependency surface with these changes.
brandtkeller
approved these changes
Oct 9, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cluster
so as to not duplicateconnect
invocationswait
schema to be more aligned toresource-rule
(since all thekind
logic is no longer needed - also makes it easier to validate user inputs before passing to wait routine):Related Issue
Fixes #229
Type of change
Checklist before merging