-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api domain): extend options for Get requests #766
Open
mildwonkey
wants to merge
11
commits into
main
Choose a base branch
from
mildwonkey/api-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+669
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildwonkey
force-pushed
the
mildwonkey/api-options
branch
from
October 28, 2024 14:20
ecafc76
to
7ed06c9
Compare
mildwonkey
changed the title
feat(api domain): Extend options for Get requests
feat(api domain): extend options for Get requests
Oct 28, 2024
6 tasks
mildwonkey
commented
Oct 29, 2024
mildwonkey
force-pushed
the
mildwonkey/api-options
branch
from
October 30, 2024 14:39
9a224e2
to
687ac14
Compare
meganwolf0
reviewed
Oct 30, 2024
meganwolf0
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This was originally a comment about how something didn't work as expected, but then I realized I had the wrong spec structure 🤦♀️ )
Anyway, did some local testing and everything worked swimmingly!
meganwolf0
previously approved these changes
Oct 31, 2024
brandtkeller
reviewed
Nov 3, 2024
meganwolf0
approved these changes
Nov 6, 2024
brandtkeller
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the optional configuration for API Domain Get methods:
I wanted to work through the PR review before I spend too much time on documentation so I opened separate docs tickets for each phase (I split up the main API Domain Optionality ticket by HTTP method to keep the PRs smallish).
Some notes of interest to reviews:
Request
as a full override of any top-level api options. I'm open to adding a flag to make that a merging behavior but wanted feedback before adding that (user or 🦄)Related Issue
Fixes #765 (documentation is a separate PR)
Type of change
Checklist before merging