Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: catch & log errors during log sift() #64

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

btlghrants
Copy link
Collaborator

Relates #63

Adds a more explicit error message when log parsing with the sift() helper runs into a non-JSON line in the log stream.

@btlghrants btlghrants self-assigned this Sep 10, 2024
@btlghrants btlghrants marked this pull request as ready for review September 10, 2024 20:17
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can help us discover the recently issues with running the e2e in Pepr Core

@cmwylie19 cmwylie19 merged commit 22aa92b into main Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants