Resolve eslint complexity warnings
#1248
Comments
5 tasks
btlghrants
pushed a commit
that referenced
this issue
Oct 30, 2024
…1333) ## Description This PR is part of the effort to reduce complexity in the code. Instead of using ternaries that are chained together, this refactor introduces a [FilterChain](https://docs.spring.io/spring-security/reference/servlet/architecture.html#servlet-filterchainproxy) analagous to what you might see in the Spring Framework to achieve the same outcome, improving readability and maintenance. ## Related Issue Relates to #1248 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <cmwylie19@defenseunicorns.com>
This was referenced Nov 4, 2024
5 tasks
cmwylie19
pushed a commit
that referenced
this issue
Nov 6, 2024
## Description Reverts filter-chaining from #1333 due to regressions, but keeps subsequent work. End to End Test: <!-- if applicable --> (See [Pepr Excellent Examples](https://github.com/defenseunicorns/pepr-excellent-examples)) ## Related Issue Relates to #1248 Closes #1389 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
ESlint has several warnings for complexity violations across the codebase. Resolve these warnings.
This is a large issue that will require multiple PRs to address. Contributors are welcome to open up a smaller, targeted issue and resolve a single complexity warning to keep the size of work to a smaller chunk. We'll use cross-references to this issue to correlate changes.
Definition of Done
complexitycomplexityis set toerrorfromwarnin.eslintrc.jsonAdditional context
Run the linter with
npm format:checkThe text was updated successfully, but these errors were encountered: