Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add static-analysis checks to CI/CD #1219

Merged
merged 25 commits into from
Oct 9, 2024
Merged

Conversation

samayer12
Copy link
Collaborator

Description

There are additional code quality checks we can run in CI. This PR adds some of them.

Related Issue

Fixes #1198

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.82%. Comparing base (a52de6e) to head (36ce279).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1219   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files          29       29           
  Lines        1411     1411           
  Branches      329      304   -25     
=======================================
  Hits         1211     1211           
- Misses        182      198   +16     
+ Partials       18        2   -16     

see 4 files with indirect coverage changes

@samayer12 samayer12 force-pushed the 1198-ci-scanning branch 7 times, most recently from 303d1ec to e73ece3 Compare October 3, 2024 20:21
@samayer12
Copy link
Collaborator Author

samayer12 commented Oct 9, 2024

There's follow-on work for configuring SemGrep (#1245) and/or Sonarqube (#1246) that exist as separate issues.

@samayer12 samayer12 marked this pull request as ready for review October 9, 2024 20:23
@samayer12 samayer12 requested a review from a team as a code owner October 9, 2024 20:23
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some good enhancements, lgtm

@cmwylie19 cmwylie19 merged commit 0d3a5b2 into main Oct 9, 2024
44 of 45 checks passed
@cmwylie19 cmwylie19 deleted the 1198-ci-scanning branch October 9, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Bring Static Code Analysis Tool into CI
2 participants