-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add static-analysis checks to CI/CD #1219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 29 29
Lines 1411 1411
Branches 329 304 -25
=======================================
Hits 1211 1211
- Misses 182 198 +16
+ Partials 18 2 -16 |
samayer12
force-pushed
the
1198-ci-scanning
branch
7 times, most recently
from
October 3, 2024 20:21
303d1ec
to
e73ece3
Compare
samayer12
force-pushed
the
1198-ci-scanning
branch
from
October 3, 2024 20:25
e73ece3
to
971f64e
Compare
samayer12
force-pushed
the
1198-ci-scanning
branch
from
October 9, 2024 16:26
5205ad5
to
a977600
Compare
samayer12
force-pushed
the
1198-ci-scanning
branch
from
October 9, 2024 16:32
5913bec
to
df01992
Compare
samayer12
force-pushed
the
1198-ci-scanning
branch
from
October 9, 2024 18:28
55e9d96
to
c468bda
Compare
samayer12
force-pushed
the
1198-ci-scanning
branch
from
October 9, 2024 19:26
b4c2604
to
7336000
Compare
samayer12
force-pushed
the
1198-ci-scanning
branch
from
October 9, 2024 19:36
6191948
to
06fe8d3
Compare
cmwylie19
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some good enhancements, lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are additional code quality checks we can run in CI. This PR adds some of them.
Related Issue
Fixes #1198
Type of change
Checklist before merging