Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix circular dependencies related to types.ts #1339

Closed
wants to merge 12 commits into from

Conversation

schaeferka
Copy link
Contributor

Description

There are circular dependencies related to types.ts that should be fixed so that there are no circular dependencies.
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1336

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@schaeferka schaeferka added this to the v0.39.0 milestone Oct 27, 2024
@schaeferka schaeferka self-assigned this Oct 27, 2024
@schaeferka schaeferka requested a review from a team as a code owner October 27, 2024 22:01
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.40%. Comparing base (7260348) to head (8611dcb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/capability.ts 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
- Coverage   85.64%   85.40%   -0.24%     
==========================================
  Files          31       30       -1     
  Lines        1449     1453       +4     
  Branches      319      344      +25     
==========================================
  Hits         1241     1241              
+ Misses        206      193      -13     
- Partials        2       19      +17     
Files with missing lines Coverage Δ
src/lib/adjudicators.ts 100.00% <100.00%> (ø)
src/lib/enums.ts 100.00% <100.00%> (ø)
src/lib/filter.ts 94.73% <100.00%> (ø)
src/lib/finalizer.ts 100.00% <100.00%> (ø)
src/lib/mutate-request.ts 100.00% <100.00%> (ø)
src/lib/validate-request.ts 100.00% <100.00%> (ø)
src/lib/watch-processor.ts 79.20% <100.00%> (ø)
src/lib/capability.ts 92.54% <42.85%> (-2.36%) ⬇️

... and 3 files with indirect coverage changes

@schaeferka
Copy link
Contributor Author

Fix is based on using interfaces for PeprMutateRequest and PeprValidateRequest in types.ts and updating the implementation of both.

@schaeferka schaeferka marked this pull request as draft October 27, 2024 22:26
@schaeferka
Copy link
Contributor Author

Closed to try a different approach

@schaeferka schaeferka closed this Oct 29, 2024
@cmwylie19 cmwylie19 deleted the 1336-circular branch November 4, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

chore: fix circular dependency between types and validate-request
1 participant