Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error in metrics.ts related to this.#cacheMissWindows.delete(firstKey) #1352

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

schaeferka
Copy link
Contributor

Description

this.#cacheMissWindows.delete(firstKey) is generating an error related to it possibly being undefined. This should be investigated and fixed.

...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1351

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@schaeferka schaeferka self-assigned this Oct 29, 2024
@schaeferka schaeferka requested a review from a team as a code owner October 29, 2024 18:11
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.02%. Comparing base (224bdd8) to head (253dce5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   78.01%   78.02%   +0.01%     
==========================================
  Files          35       35              
  Lines        1669     1670       +1     
  Branches      370      396      +26     
==========================================
+ Hits         1302     1303       +1     
+ Misses        365      338      -27     
- Partials        2       29      +27     
Files with missing lines Coverage Δ
src/lib/metrics.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@cmwylie19 cmwylie19 merged commit a84eff2 into main Oct 29, 2024
45 of 46 checks passed
@cmwylie19 cmwylie19 deleted the 1351-metrics-fix branch October 29, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

chore: fix error in metrics.ts related to this.#cacheMissWindows.delete(firstKey)
2 participants