chore: disable cosign testing for now #1368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Had a chat w/ Sam, Kim today -- the cosign/sigstore-js tests are subject to intermittent failure in CI due to a (suspected) failed network request (which presents as an "invalid bundle"-ish error message). Changing nothing & simply rerunning the CI job is usually enough to "fix it", but... that's not the kind of thing we want to have to constantly be doing.
So, while we will have to dig into that more in the future -- probably once the cosign signature verification helper graduates from "spike" status -- we're just going to disable running these tests in CI for the time being. Not only will this prevent us having to see a bunch of false-fails (until we get time to go back & make this feature "real") but it should also (slightly) increase the perf of our test suite by not running tests that aren't required.
Type of change
Checklist before merging