Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable cosign testing for now #1368

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

btlghrants
Copy link
Collaborator

Description

Had a chat w/ Sam, Kim today -- the cosign/sigstore-js tests are subject to intermittent failure in CI due to a (suspected) failed network request (which presents as an "invalid bundle"-ish error message). Changing nothing & simply rerunning the CI job is usually enough to "fix it", but... that's not the kind of thing we want to have to constantly be doing.

So, while we will have to dig into that more in the future -- probably once the cosign signature verification helper graduates from "spike" status -- we're just going to disable running these tests in CI for the time being. Not only will this prevent us having to see a bunch of false-fails (until we get time to go back & make this feature "real") but it should also (slightly) increase the perf of our test suite by not running tests that aren't required.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants self-assigned this Oct 31, 2024
@btlghrants btlghrants marked this pull request as ready for review October 31, 2024 16:55
@btlghrants btlghrants requested a review from a team as a code owner October 31, 2024 16:55
@cmwylie19 cmwylie19 changed the title chore: disable cosign testing (for now). chore: disable cosign testing for now Oct 31, 2024
@btlghrants btlghrants merged commit e44721a into main Oct 31, 2024
44 of 45 checks passed
@btlghrants btlghrants deleted the disable_cosign_tests_for_now branch October 31, 2024 17:00
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (9dbf9ab) to head (8f96c07).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
- Coverage   79.69%   79.57%   -0.13%     
==========================================
  Files          40       39       -1     
  Lines        1945     1816     -129     
  Branches      411      396      -15     
==========================================
- Hits         1550     1445     -105     
+ Misses        365      342      -23     
+ Partials       30       29       -1     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants