Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require aws provider 4.9.0 or better due to s3 bucket deletion issue #51

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: require aws provider 4.9.0 or better due to s3 bucket deletion issue #51

merged 1 commit into from
Sep 20, 2023

Conversation

RothAndrew
Copy link
Member

Related to #47

@RothAndrew RothAndrew requested a review from a team as a code owner September 20, 2023 18:07
@RothAndrew RothAndrew self-assigned this Sep 20, 2023
zack-is-cool
zack-is-cool approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@zack-is-cool zack-is-cool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RothAndrew RothAndrew merged commit ff68809 into main Sep 20, 2023
5 checks passed
@RothAndrew RothAndrew deleted the feature/47-error-when-deleting-sessionlogs-bucket branch September 20, 2023 20:51
@RothAndrew RothAndrew mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zack-is-cool zack-is-cool zack-is-cool approved these changes

Assignees

@RothAndrew RothAndrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RothAndrew @zack-is-cool