fix: split override envs properly (#829)

defenseunicorns · Jul 19, 2024 · f6360e5 · f6360e5
1 parent 6ca1dd9
commit f6360e5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/pkg/bundle/overrides.go b/src/pkg/bundle/overrides.go
@@ -68,7 +68,7 @@ func (b *Bundle) loadVariables(pkg types.Package, bundleExportedVars map[string]
 	// env vars (vars that start with UDS_)
 	for _, envVar := range os.Environ() {
 		if strings.HasPrefix(envVar, config.EnvVarPrefix) {
-			parts := strings.Split(envVar, "=")
+			parts := strings.SplitN(envVar, "=", 2)
 			pkgVars[strings.ToUpper(strings.TrimPrefix(parts[0], config.EnvVarPrefix))] = parts[1]
 			overVarsData[strings.ToUpper(strings.TrimPrefix(parts[0], config.EnvVarPrefix))] = overrideData{parts[1], valuesources.Env}
 		}

diff --git a/src/test/e2e/variable_test.go b/src/test/e2e/variable_test.go
@@ -267,7 +267,7 @@ func TestBundleWithEnvVarHelmOverrides(t *testing.T) {
 	e2e.HelmDepUpdate(t, "src/test/packages/helm/unicorn-podinfo")
 	e2e.CreateZarfPkg(t, "src/test/packages/helm", false)
 	color := "purple"
-	b64Secret := "dGhhdCBhaW50IG15IHRydWNr"
+	b64Secret := "dGhhdCBhaW50IG15IHRydWNrCg=="
 	err := os.Setenv("UDS_CONFIG", filepath.Join("src/test/bundles/07-helm-overrides", "uds-config.yaml"))
 	require.NoError(t, err)
 	err = os.Setenv("UDS_UI_COLOR", color)