Skip to content

Commit

Permalink
fix: eks iac issues, document storage class pre-reqs (#812)
Browse files Browse the repository at this point in the history
EBS impose a 1Gi size limitation on restored PVCs. This adds a short
note to pre-reqs about checking CSI limitations.

While testing with our EKS IAC I also discovered a few other issues:
- IRSA annotations were not correct
- Config did not properly variablize region
- Config had an unmatched `"` around one of the values
- Gitignore did not exclude terraform/tfstate files that shouldn't be
committed

Fixes #718

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
  • Loading branch information
mjnagel authored and docandrew committed Oct 17, 2024
1 parent 1d95470 commit fad6384
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/bundles/rke2/uds-bundle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ packages:
path: credentials.useSecret
- name: VELERO_IRSA_ROLE_ARN
description: "IRSA ARN annotation to use for Velero"
path: serviceAccount.server.annotations.irsa/role-arn
path: serviceAccount.server.annotations.eks\.amazonaws\.com/role-arn
loki:
loki:
values:
Expand All @@ -78,4 +78,4 @@ packages:
path: loki.storage.s3.region
- name: LOKI_IRSA_ROLE_ARN
description: "The irsa role annotation"
path: serviceAccount.annotations.irsa/role-arn
path: serviceAccount.annotations.eks\.amazonaws\.com/role-arn

0 comments on commit fad6384

Please sign in to comment.