Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: secret copy #741 #948

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: secret copy #741 #948

wants to merge 4 commits into from

Conversation

docandrew
Copy link
Contributor

Description

Related Issue

Fixes #741

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@docandrew docandrew requested a review from a team as a code owner October 21, 2024 17:06
@bburky
Copy link
Member

bburky commented Oct 21, 2024

This appears to be unprivileged and effectively allows cluster-wide read of any Secrets if you have RBAC permissions of read/write to a Secret in a single namespace. Also, because the name is customizable, this is a bypass of resourceNames RBAC too.

It's reasonable for an app to have runtime read/write secrets in it's own namespace (possibly restricted by resourceNames) , but this would allow reading any secret in the cluster.

There's a few different ways you could address this, but I'd suggest driving it via a CR instead of the Secret resources alone. For example, editing Package resources is privileged (things shouldn't be giving away RBAC to this resource kind), which drives most of this operator and solves the permissions issue.

This is isn't a comment on the feature itself, I have no opinion on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets manipulation using the UDS Operator
2 participants