-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: port uds-common/setup action #121
Conversation
08d1e0a
to
cc6491d
Compare
So I'm catching up a bit with what changed in uds-common, but I think instead of adding a new setup action in this repo we should just try to consume the new actions tasks wherever possible. For instance there is a task for authenticating with registries You might not be able to go a step further and consume the callable workflows that are designed for |
Signed-off-by: catsby <clint@defenseunicorns.com>
Signed-off-by: catsby <clint@defenseunicorns.com>
cc6491d
to
cbb20b3
Compare
Signed-off-by: catsby <clint@defenseunicorns.com>
@rjferguson21 please take another look when you get the chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to update the other locations this is called as well?
Signed-off-by: catsby <clint@defenseunicorns.com>
@mjnagel that would indeed make sense 🤦♂️ |
Description
Copy-over the now-removed
uds-common/.github/actions/setup
action into this repo. UDS Common was refactored and some actions were removed, so here wecopy what this action was as of versionadopt the uds actions that are in uds-common now.v0.13.1
Original:
In this lift-and-shift I replaced the steps for installing UDS CLI with the new, dedicated action for it at https://github.com/defenseunicorns/setup-uds.Note: some of the inputs may not be relevant anymore, but I'm not entirely sure. Our usage supplies ausername
andpassword
, but I don't see where the Action actually uses those, if at all. Additionally, I don't have the right access to see what secrets this repo (uds-k3d
) has, so I don't what it might be putting in to the environment.Related Issue
Relates to #116 which is a PR from Renovate that wont ever work because the latest versions of uds-common no longer have the referenced Action.
Type of change
Checklist before merging