Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port uds-common/setup action #121

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Oct 28, 2024

Description

Copy-over the now-removed uds-common/.github/actions/setup action into this repo. UDS Common was refactored and some actions were removed, so here we copy what this action was as of version v0.13.1 adopt the uds actions that are in uds-common now.

Original:

In this lift-and-shift I replaced the steps for installing UDS CLI with the new, dedicated action for it at https://github.com/defenseunicorns/setup-uds.

Note: some of the inputs may not be relevant anymore, but I'm not entirely sure. Our usage supplies a username and password, but I don't see where the Action actually uses those, if at all. Additionally, I don't have the right access to see what secrets this repo (uds-k3d) has, so I don't what it might be putting in to the environment.

Related Issue

Relates to #116 which is a PR from Renovate that wont ever work because the latest versions of uds-common no longer have the referenced Action.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@catsby catsby requested a review from a team as a code owner October 28, 2024 21:48
@catsby catsby force-pushed the build-test-setup-env-action branch from 08d1e0a to cc6491d Compare October 28, 2024 22:22
@rjferguson21
Copy link
Contributor

So I'm catching up a bit with what changed in uds-common, but I think instead of adding a new setup action in this repo we should just try to consume the new actions tasks wherever possible.

For instance there is a task for authenticating with registries

You might not be able to go a step further and consume the callable workflows that are designed for uds-packages-* but it might end up being a better fit to just directly consume the uds tasks directly for this repo.

Signed-off-by: catsby <clint@defenseunicorns.com>
Signed-off-by: catsby <clint@defenseunicorns.com>
@catsby catsby force-pushed the build-test-setup-env-action branch from cc6491d to cbb20b3 Compare October 30, 2024 20:12
Signed-off-by: catsby <clint@defenseunicorns.com>
Signed-off-by: catsby <clint@defenseunicorns.com>
@catsby
Copy link
Contributor Author

catsby commented Nov 4, 2024

@rjferguson21 please take another look when you get the chance

Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: catsby <clint@defenseunicorns.com>
@catsby
Copy link
Contributor Author

catsby commented Nov 4, 2024

@mjnagel that would indeed make sense 🤦‍♂️
I updated those as well. The setup-environment UDS Task should handle the Login to GHCR step we had here originally, so that should still be covered

@catsby catsby requested a review from mjnagel November 4, 2024 18:25
@catsby catsby merged commit b2ed83f into main Nov 4, 2024
3 checks passed
@catsby catsby deleted the build-test-setup-env-action branch November 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants