Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change to use uds-common test action #36

Merged
merged 25 commits into from
Mar 13, 2024

Conversation

ericwyles
Copy link
Contributor

@ericwyles ericwyles commented Mar 6, 2024

Description

Updated the test workflow to use new test action from uds-common

Updated other uds-common references to the latest version.

Related Issue

Relates to defenseunicorns/uds-software-factory#17

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@ericwyles ericwyles self-assigned this Mar 12, 2024
@ericwyles ericwyles changed the title chore: consolidate workflows to uds-common chore: change to use uds-common test action Mar 12, 2024
@ericwyles ericwyles marked this pull request as ready for review March 12, 2024 14:38
@ericwyles ericwyles requested a review from a team as a code owner March 12, 2024 16:28
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review before mtg.

.github/workflows/tag-and-release.yaml Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest of comments

.github/workflows/test.yaml Show resolved Hide resolved
tasks.yaml Show resolved Hide resolved
@ericwyles
Copy link
Contributor Author

@Racer159 I think this one is ready for another look. It'll need updates from an owner for the 'Required' checks that are listed as 'Expected' now because names changed with the consolidation.

@ericwyles ericwyles requested a review from Racer159 March 12, 2024 21:21
@zachariahmiller
Copy link
Contributor

@ericwyles updated the required checks for the name change not sure why this one is still showing the old ones...

anyways this had the docs shim merged and as such will also need the job name for that updated to match the test.

- name: Shim for Deploy ${{ matrix.flavor }}

hopefully fixing that will reset the required checks to the current ones 🤔

@zachariahmiller
Copy link
Contributor

I actually just went and did it so we dont have to think about it tomorrow not sure about the checks though. Will send over to @Racer159 for approval since i now have last commit 😢

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (the save logs doesn't have a trailing new line but that's probably fine for now and really a nit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants