-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change to use uds-common test action #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review before mtg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest of comments
@Racer159 I think this one is ready for another look. It'll need updates from an owner for the 'Required' checks that are listed as 'Expected' now because names changed with the consolidation. |
@ericwyles updated the required checks for the name change not sure why this one is still showing the old ones... anyways this had the docs shim merged and as such will also need the job name for that updated to match the test.
hopefully fixing that will reset the required checks to the current ones 🤔 |
I actually just went and did it so we dont have to think about it tomorrow not sure about the checks though. Will send over to @Racer159 for approval since i now have last commit 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (the save logs doesn't have a trailing new line but that's probably fine for now and really a nit)
Description
Updated the test workflow to use new test action from uds-common
Updated other uds-common references to the latest version.
Related Issue
Relates to defenseunicorns/uds-software-factory#17
Type of change
Checklist before merging