-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to upstream chart directly #6
Conversation
This is still a WIP, need to make some of the setup less gross with the config, probably by shoving more of the secret creation to the uds-config chart to ensure it is seamless with empty values. |
This should be ready for a review - interested in feedback on the approach taken for wiring up dependencies. I left this as a pretty minimal approach where the zarf package really won't work on its own outside of the context of a bundle where helm values are exposed. I think there's two other options though:
I kind of lean towards leaving this as-is. Since it is a UDS package I think we should be comfortable assuming UDS CLI, assuming proper documentation. But would prefer alternative opinions to weigh in. If https://www.github.com/mattermost/mattermost-helm/pull/440 were to get merged upstream it would make me feel more comfortable about the magic secret path since we wouldn't need to set particular keys in given secrets. |
@mjnagel - i am in agreement with merging this PR as-is and refactoring once the helm chart adopts the envFrom change you proposed. on another note, do we have a way to influence the hostname portion of the virtual service? for example could we deploy this in a way to get |
@MxNxPx I have no problem switching to |
How would you feel about templating host in the uds-package cr with a default and then not "exposing" subdomain per se, but someone could purposefully override it in their bundle? |
@zachariahmiller yeah definitely can make that a helm value if we want, it would be easy. I can go ahead and make that switch, was just noting that this isn't something we have done on any other UDS packages to date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Burn some boats.