Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test remote tasks #30

Closed
wants to merge 6 commits into from
Closed

ci: test remote tasks #30

wants to merge 6 commits into from

Conversation

mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Jan 24, 2024

WIP: Need to add renovate tracking + validate the publish pattern with remote tasks and versioning.

@mjnagel mjnagel self-assigned this Jan 24, 2024
@rjferguson21
Copy link

rjferguson21 commented Jan 24, 2024

One thought I'm having is the remote task files are could be tied to a particular version of the UDS/Zarf binary. Maybe it is on the importer to know which versions the source repo installed.

@mjnagel
Copy link
Contributor Author

mjnagel commented Jan 24, 2024

@rjferguson21 Not sure if this comment was meant for here or the common-tasks PR, but that's totally valid. Not a complete solve but I have the tasks being tested in that repo with specific uds-cli and zarf versions, with the same version documented in the readme. Those versions are all tracked by renovate and should be updated at the same time.

The versioning also might get simpler if we start publishing actions with the setup stuff (installing uds/zarf) as well as the task pieces, then a repo is just consuming a given action and doesn't have to worry about their own version setup.

@TristanHoladay TristanHoladay marked this pull request as ready for review January 29, 2024 19:01
@TristanHoladay TristanHoladay requested a review from a team as a code owner January 29, 2024 19:01
@zachariahmiller
Copy link
Contributor

Sorry @TristanHoladay Is this still relevant/ready for review? If so can you resolve conflicts and ping me again for review. Thanks!

@Racer159
Copy link
Contributor

This is OBE as of #60

@Racer159 Racer159 closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants