Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): 435 truncated table cells #449

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

feat(ui): 435 truncated table cells #449

wants to merge 59 commits into from

Conversation

BillyFigueroa
Copy link
Contributor

@BillyFigueroa BillyFigueroa commented Oct 15, 2024 •
edited
Loading

Description

Changes included in this PR

  • Converting table layout to a more fluid/ responsive non table layout
  • Adding sizing to every single table using the DataTable component
  • Moving all table column definitions for emphasizing first column to Datatable
  • Ensure truncation is added as tables re-size

Changes not included in this PR

  • This PR does not include converting the table pages that are not using the Datatable i.e. Pepr/ Event pages

Related Issue

Screenshots

Before

Screenshot 2024-10-22 at 3 32 12 PM

After

Screenshot 2024-10-22 at 3 43 52 PM

@BillyFigueroa BillyFigueroa self-assigned this Oct 15, 2024
@BillyFigueroa BillyFigueroa linked an issue Oct 15, 2024 that may be closed by this pull request
Truncated Table Cells #435
Open
@BillyFigueroa
refactor: updating monitor events table & tests
dff554e
@BillyFigueroa
refactor: updating workloads deployment and tests
2515326
@BillyFigueroa
fix: correcting lint errors
6f6b7c5
@BillyFigueroa
refactor: updating workloads daemonsets and tests
edd0b88
@BillyFigueroa
refactor: updating workloads statefulsets and tests
9c262e8
@BillyFigueroa
refactor: updating workloads ctronjobs and tests
ee3fdf2
@BillyFigueroa
refactor: refacotring truncating logic
30b2e3d
@BillyFigueroa
refactor: updating all config routes
1a2d6f3
@BillyFigueroa
refactor: updating all cluster ops routes
0bb606e
@BillyFigueroa
Merge branch 'main' into 435-truncated-table-cells
8279fc3
@BillyFigueroa
refactor: updating all network routes
0dace95
@BillyFigueroa
refactor: updating all storage routes
afd29ca
@BillyFigueroa
refactor: removing unsed component ref
fb93265
@BillyFigueroa
refactor: updating Namespaces and Nodes route
8cbc5a2
@BillyFigueroa
refactor: updating app.postcss to use classes for non table layout
f89d4c5
@BillyFigueroa
refactor: moving emphasize class to datable for workloads
1e0d0a1
@BillyFigueroa
refactor: removing emphasize from all table col defs and moving to da…
e484c35 
…tatable
@BillyFigueroa
chore: merging main
f13a3bf
@BillyFigueroa
Merge branch 'main' into 435-truncated-table-cells
e365af5
@BillyFigueroa
refactor: updating events table column widths
e4d45db
@BillyFigueroa
refactor: updating pods table
0d1257d
@BillyFigueroa
refactor: updating configs
a730017
@BillyFigueroa
fix: fixing navigation help test
83bb16f
@BillyFigueroa
Merge branch 'main' into 435-truncated-table-cells
14af135
BillyFigueroa and others added 20 commits October 17, 2024 12:17
@BillyFigueroa
fix: updating front end unit tests
837d4de
@BillyFigueroa
fix: formatting test
b722618
@BillyFigueroa
fix: updating invalid expect locator
7d71372
@BillyFigueroa
fix: readding expect dependency
db46503
@BillyFigueroa
fix: updating test spec
e43dafb
@BillyFigueroa
fix: trying to fix local auth test
f7c692a
@BillyFigueroa
chore: adding expect
b82eede
@BillyFigueroa
Merge branch 'main' into 435-truncated-table-cells
da916fd
@BillyFigueroa
fix: sectioning local-auth tests 1
46ae8fd
@decleaver
Merge branch 'main' into 435-truncated-table-cells
cf2e9ba
@decleaver
local-auth test debugging
917b93f
@BillyFigueroa
Merge branch 'main' into 435-truncated-table-cells
311e5a9
@BillyFigueroa
refactor: making namespace truncate-able
4510f26
@BillyFigueroa
refactor: making status column truncate-able
d32d2d8
@BillyFigueroa
chore: merging main
4095221
@BillyFigueroa
fix: re-adding test step
f252911
@BillyFigueroa
fix: updating tables with line-clamp
a77d1c5
@BillyFigueroa
fix: fixing local auth test
f35fae0
@BillyFigueroa
fix: updating tests
e46f831
@BillyFigueroa
fix: fixing table.spec tests
c062f4e
@BillyFigueroa BillyFigueroa marked this pull request as ready for review October 22, 2024 21:06
@BillyFigueroa BillyFigueroa requested a review from a team as a code owner October 22, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BillyFigueroa BillyFigueroa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Truncated Table Cells
3 participants
@BillyFigueroa @decleaver @UncleGedd