Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds health check #465

Merged
merged 7 commits into from
Oct 18, 2024
Merged

feat: adds health check #465

merged 7 commits into from
Oct 18, 2024

Conversation

UncleGedd
Copy link
Contributor

@UncleGedd UncleGedd commented Oct 17, 2024 •
edited
Loading

Description

  • renames /health -> /cluster-check
  • adds a health check endpoint

Relates to #442

@UncleGedd UncleGedd requested a review from a team as a code owner October 17, 2024 16:20
@UncleGedd UncleGedd marked this pull request as draft October 17, 2024 16:20
@UncleGedd
Copy link
Contributor Author

UncleGedd commented Oct 17, 2024 •
edited
Loading

Our chainguard/static image doesn't have a sh so it isn't clear if we can implement a health check at the image level. Currently waiting on a response from the IB team

EDIT: no HEALTHCHECK directive necessary

@UncleGedd UncleGedd marked this pull request as ready for review October 18, 2024 17:44
@TristanHoladay
Copy link
Contributor

LGTM. just curious if the /healthz endpoint is a requirement or just best practice that we make available for people but we don't use it ourselves?

@UncleGedd
Copy link
Contributor Author

LGTM. just curious if the /healthz endpoint is a requirement or just best practice that we make available for people but we don't use it ourselves?

Best practice, especially when used for automated observability

TristanHoladay
TristanHoladay previously approved these changes Oct 18, 2024
View reviewed changes
catsby
catsby approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pkg/api/docs/swagger.json Show resolved Hide resolved
@UncleGedd UncleGedd merged commit 9e14fc2 into main Oct 18, 2024
13 checks passed
@UncleGedd UncleGedd deleted the add-health-check branch October 18, 2024 19:10
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Merged
@TristanHoladay TristanHoladay mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decleaver decleaver decleaver approved these changes

@catsby catsby catsby approved these changes

@TristanHoladay TristanHoladay TristanHoladay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UncleGedd @TristanHoladay @catsby @decleaver