fix(ui): url updates from link clicks not showing current route in sidenav #522
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decleaver
approved these changes
Nov 1, 2024
TristanHoladay
deleted the
487-side-nav-not-showing-current-path-after-click-view-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Highlights the current route in the sidenav after clicking button or card that is a link. The problem was that if the link was to a route that is a child route (e.g. /workloads/pods) and the workloads dropdown wasn't open then, even though active, the child route remained hidden.
This fix reactively looks at
$page.url.pathnameto open the correct dropdown if needed, and thus show the child route. The function is extracted so that the only variable svelte is looking at when deciding to trigger the update logic is$page.url.pathname. Attempts at making the entire function reactive resulted in the update logic firing when the dropdown button was toggled, meaning the submenu would be toggled off and then immediately back on.Related Issue
resolves #487
Screencast.from.11-01-2024.01.59.22.PM.webm