1 tx delegation #190
Merged
1 tx delegation #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify track selection
Deploying delegit with
|
| Latest commit: |
bd37d06
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae168615.delegit.pages.dev |
| Branch Preview URL: | https://tbaut-1tx-delegation.delegit.pages.dev |
wirednkod
reviewed
Oct 21, 2024
| onOpenChange={onOpenChange} | ||
| callData={promptForHelpCallData} | ||
| /> | ||
| ) | ||
|
|
||
| return ( | ||
| <Dialog open={isOpen} onOpenChange={onOpenChange}> | ||
| <Dialog open onOpenChange={onOpenChange}> |
There was a problem hiding this comment.
This should be isOpen - no?
Suggested change
| <Dialog open onOpenChange={onOpenChange}> | |
| <Dialog isOpen onOpenChange={onOpenChange}> |
There was a problem hiding this comment.
no, you can see the previous was open={isOpen}, leaving just open means it'll be true always, which is what I want to achieve. The opening is managed differently here.
wirednkod
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were still forcing a 2 tx flow, with an empty batch, when there was nothing to unvote/undelegate.
Now if you arrive with no prior interaction with opengov, you can delegate in 1 tx.