Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 tx delegation #190

Merged
merged 18 commits into from
Oct 21, 2024
Merged

1 tx delegation #190

merged 18 commits into from
Oct 21, 2024

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Oct 19, 2024

We were still forcing a 2 tx flow, with an empty batch, when there was nothing to unvote/undelegate.

Now if you arrive with no prior interaction with opengov, you can delegate in 1 tx.

@Tbaut Tbaut requested a review from wirednkod as a code owner October 19, 2024 21:30
Copy link

Deploying delegit with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd37d06
Status: ✅  Deploy successful!
Preview URL: https://ae168615.delegit.pages.dev
Branch Preview URL: https://tbaut-1tx-delegation.delegit.pages.dev

View logs

onOpenChange={onOpenChange}
callData={promptForHelpCallData}
/>
)

return (
<Dialog open={isOpen} onOpenChange={onOpenChange}>
<Dialog open onOpenChange={onOpenChange}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be isOpen - no?

Suggested change
<Dialog open onOpenChange={onOpenChange}>
<Dialog isOpen onOpenChange={onOpenChange}>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, you can see the previous was open={isOpen}, leaving just open means it'll be true always, which is what I want to achieve. The opening is managed differently here.

@Tbaut Tbaut requested a review from wirednkod October 21, 2024 09:23
@Tbaut Tbaut merged commit de3746d into main Oct 21, 2024
3 checks passed
@Tbaut Tbaut deleted the tbaut/1tx-delegation branch October 21, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants