Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network issues #57

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix network issues #57

merged 1 commit into from
Aug 28, 2024

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Aug 28, 2024 •
edited
Loading

  • set the network to 1 rpc
  • set the network list as O(1) to remove complexity
  • move trusted RPC to the beginning, no need to play with these now.
  • remove some utils that make things complex IMHO
  • return an object rather than a tuple for getNetworkInformation

ps: although it may not seem like it, getNetworkInformation is actually strongly typed and doesn't accept just any string. It'd only accept what's in the network list.

@Tbaut Tbaut requested a review from wirednkod August 28, 2024 15:55
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying delegit with  Cloudflare Pages  Cloudflare Pages

Latest commit: 47dcb44
Status: ✅  Deploy successful!
Preview URL: https://8e4588f0.delegit.pages.dev
Branch Preview URL: https://tbaut-network-set.delegit.pages.dev

View logs

@wirednkod wirednkod merged commit 01ed8ab into main Aug 28, 2024
3 checks passed
@wirednkod wirednkod deleted the tbaut-network-set branch August 28, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirednkod wirednkod wirednkod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tbaut @wirednkod