-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update JAVA_HOME to adoptopenjdk #67
Conversation
Instead of making this change, can we just remove the setting of
So, I'd suggest we change consumers to stop relying on If this isn't possible, then I'd rather us move where If we don't want to do either of these, then I'm OK with this change. This makes things no worse than they are today, but if we're already making changes to this code, I think it'd be a good time to reduce the technical debt here. Sorry for the long reply; please let me know if I should clarify on anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the advantage of getting rid of JAVA_HOME
is that we then do not need to modify it whenever we switch Java versions. That said we still need to change the java package dependency that each java user package (virtualization, masking, sso) has, so it won't gain us that much. We could create a new light-weight package, something like delphix-java
, which can be pulled as a dependency by the other packages and would be responsible of setting JAVA_HOME (or even get rid of JAVA_HOME as Prakash has suggested). That said, I think this can be done as a follow-up work, so I don't block this.
Regarding the PR description, It would be useful to add a section which explains the various dependencies that this change has on other repositories, as well as an appliance-build-orchestrator run with the appropriate changes.
✌️ sravyamks can now approve this pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My prior comment still stands, but if we want to go forward with this approach, I approve this as-is.
bors delegate+
I agree with @prakashsurya's suggestion to get rid of our reliance on We still need to support illumos, and the version of In contrast, if we wait until after we drop support for illumos, then we can just remove all references to Based on this reasoning, I think we should postpone the refactoring proposed here until after we drop support for illumos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The delphix-platform
change looks good to me. I have some feedback on the Ansible changes to dlpx-app-gate
and dms-core-gate
, but I will leave those on Review Board once those reviews are posted there.
Thanks @basil. That sounds reasonable to me. |
Thank you everyone for reviewing - below are the updated review requests and builds Testing: saml-app - app-gate - masking - linux-pkg - appliance-build-orchestrator-pre-push : http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/806/ Test java version on a VM from image created (
|
bors r+ |
67: update JAVA_HOME to adoptopenjdk r=sravyamks a=sravyamks update JAVA_HOME to adoptopenJDK **Testing:** Linux-pkg run using forked branch of `delphix-platform` - http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/linux-pkg-build/job/master/job/userland/job/pre-push/15/ appliance-build-orchestrator-pre-push : http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/792/ (still running) Other related changes for appliance-build-orchestrator run - app-gate - changes : https://gitlab.delphix.com/sravya.meda/dlpx-app-gate/commit/d382bb892ff50a936a44d824941099b0143ed037 build : http://selfservice.jenkins.delphix.com/job/dlpx-app-gate/job/master/job/build-package/job/pre-push/442/ masking - changes : https://gitlab.delphix.com/sravya.meda/dms-core-gate/commit/eddc19da356052cecd5a14ead45f838e07fae321 build - http://selfservice.jenkins.delphix.com/job/dms-core-gate/job/master/job/build-package/job/pre-push/71/ saml-app - changes : https://gitlab.delphix.com/sravya.meda/saml-app/commit/66aabbcee3b47171f625a8a5da9f3a9b0ab5f54e Verify JAVA_HOME on a VM from appliance build image - ``` delphix@ip-10-110-236-58:~$ echo $JAVA_HOME /usr/lib/jvm/adoptopenjdk-java8-jdk-amd64 ``` Co-authored-by: Sravya Meda <sravya.mks@gmail.com>
Build succeeded
|
update JAVA_HOME to adoptopenJDK
Testing:
Linux-pkg run using forked branch of
delphix-platform
- http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/linux-pkg-build/job/master/job/userland/job/pre-push/15/appliance-build-orchestrator-pre-push : http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/792/ (still running)
Other related changes for appliance-build-orchestrator run -
app-gate -
changes : https://gitlab.delphix.com/sravya.meda/dlpx-app-gate/commit/d382bb892ff50a936a44d824941099b0143ed037
build : http://selfservice.jenkins.delphix.com/job/dlpx-app-gate/job/master/job/build-package/job/pre-push/442/
masking -
changes : https://gitlab.delphix.com/sravya.meda/dms-core-gate/commit/eddc19da356052cecd5a14ead45f838e07fae321
build - http://selfservice.jenkins.delphix.com/job/dms-core-gate/job/master/job/build-package/job/pre-push/71/
saml-app -
changes : https://gitlab.delphix.com/sravya.meda/saml-app/commit/66aabbcee3b47171f625a8a5da9f3a9b0ab5f54e
Verify JAVA_HOME on a VM from appliance build image -