add Java 8 #21
Merged
add Java 8 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebroy
approved these changes
Mar 7, 2019
prakashsurya
reviewed
Mar 7, 2019
|
@prakashsurya I've added comments in the code that provide more details on why we do certain things. |
prakashsurya
reviewed
Mar 7, 2019
prakashsurya
reviewed
Mar 7, 2019
prakashsurya
approved these changes
Mar 7, 2019
bors bot
added a commit
to delphix/appliance-build
that referenced
this pull request
Mar 8, 2019
245: Java is now built by Linux-pkg r=pzakha a=pzakha Following the integration of delphix/linux-pkg#21, we can now remove the build of Java8 from here. ## TESTING ab-pre-push: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/654/ Co-authored-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Java 8 package to Linux-pkg.
The main goal here is to stop building Java in appliance-build and do it in Linux-pkg instead. This is also a prerequisite for adding the SSO app to Linux-pkg.
NEXT STEPS
Remove Java build from appliance-build
TESTING