Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication middleware #39

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

tdikland
Copy link
Contributor

The Delta Sharing server needs to know an identifier of the recipient in order to apply the appropriate access control policies.

The auth module contains the primitives for building your own authentication and/or authorization layers for the Delta Sharing server. There is also a simple implementation for servers that have no access control policies (i.e. all shares are public and can be accessed anonymously).

Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, particularly nice work on the docs :).

Left one minor question.

/// assert!(recipient_id.is_unknown());
/// ```
pub fn is_unknown(&self) -> bool {
matches!(self, RecipientId::Unknown)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do Self::Unknown here as well to be consistent?

@roeap roeap merged commit c041305 into delta-incubator:main May 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants