Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current user mgmt #1715

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Current user mgmt #1715

wants to merge 32 commits into from

Commits on Oct 8, 2024

  1. Add Pre File Fetch Sensitivity Check (#1652)

    * Add Pre File Fetch Sensitivity Check
    
    - Verify user and veteran sensitivity levels are compatible.
    
    - Add specs and supporting services needed to perform sensitivity
    level checks.
    
    * Implement Banner for Unauthorized Vet Access
    
    * Restore Old Error Message Logic
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5b3c218 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9a2f77 View commit details
    Browse the repository at this point in the history
  3. Gate VBMS Methods with Sensitivity Checks (#1665)

    * Gate VBMS Methods with Sensitivity Checks
    
    Validate user access to veteran before allowing fetch of veteran
    data.
    
    * Remove Unneeded allow Directives in Spec
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9557efd View commit details
    Browse the repository at this point in the history
  4. Remove Unneeded Sensitivity Checks (#1666)

    * Remove Unneeded Sensitivity Checks
    
    Checks are already handled by the sensitive_record method.
    
    * Fix Non-Forbidden Banner Styling
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f1d396f View commit details
    Browse the repository at this point in the history
  5. Restore Pre-Fetch Sensitivity Check Logic & Add Frontend Feature Togg…

    …le (#1667)
    
    * Pass Sensitivity Check Feature Toggle to UI
    
    * Restore Manifest Sensitivity Logic
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    af9d251 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e9fd8ab View commit details
    Browse the repository at this point in the history
  7. Fix Missing Manifest User Causing Sensitivity Check Failures (#1675)

    * Fix User Missing for BGS Sensitivity Check
    
    - Update the manifests_controller's refresh method to use the
      find_or_create_by_user method to find a manifest. This will
      ensure that the user is set correctly for BGS calls.
    
    - Move SensitivityLevelCheckFailure logic to the base_controller.
    
    * Fix Misc. Issues
    
    - Move rescue_from for BGS errors into the API V1 controller so
      its existing standard error rescue doesn't catch this exception.
    
    - Improve manifests_controller request spec with sensitivity check
      logic.
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    01576e4 View commit details
    Browse the repository at this point in the history
  8. Use New Sensitivity Check Method (#1676)

    - Use new method to check user/veteran sensitivity compatibility
      in the V2 ApplicationController.
    
    - This will prevent the old "use BGS error to verify access" logic
      from running.
    
    Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
    2 people authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    2f41563 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    183286b View commit details
    Browse the repository at this point in the history
  10. Send Veteran Number in Restart Request (#1679)

    * Send Veteran Number in Restart Request
    
    * Update Link rel Param
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c3d84ce View commit details
    Browse the repository at this point in the history
  11. Update CE API Gem (#1680)

    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1a22df9 View commit details
    Browse the repository at this point in the history
  12. Update Logic for Setting Veteran ID in Request (#1681)

    - Remove recently-added frontend logic for setting veteran ID in
      refresh request as it is unreliable in the way it sets the
      veteran ID.
    
    - Update manifests_controller to set the veteran ID using the
      manifest as this is much more reliable.
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0555acf View commit details
    Browse the repository at this point in the history
  13. Update JSON Parsing Logic to Handle CE API Gem Changes (#1686)

    - Gem now returns the JSON body of a HTTP response, so our
      response parsing code needed to be updated to handle the new
      format.
    
    - Update the VBMS service to alert us of any API responses that
      can't be parsed so we can troubleshoot them.
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    cb43002 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4a4f847 View commit details
    Browse the repository at this point in the history
  15. Add current_user to SaveFilesInS3 Job (#1688)

    - Since the SaveFilesInS3 job is spawned by another job, it does
      not have access to RequestStore[:current_user] which is needed
      for verifying veteran/user sensitivity compatibility.
    
    - This PR also fixes several Rubocop violations in various files.
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9e2a9a4 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6d18455 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    1eaf33c View commit details
    Browse the repository at this point in the history
  18. Kev ma/appeals 58216 time adjust (#1692)

    * Adjusted UI_EXPIRY_HOURS based on deploy environment
    
    * Adjust API HOURS
    Kevma50287 authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9322a50 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    89a91f0 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    455fef7 View commit details
    Browse the repository at this point in the history
  21. Improve Script Output (#1695)

    - Sort output by sensitivity level.
    
    - Display total result count for each level.
    tradesmanhelix authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ae2f385 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8b83f87 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    c13cb12 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    b701318 View commit details
    Browse the repository at this point in the history
  25. Kev ma/appeals 59461 (#1701)

    * Removed send_user feature flag, combined with use_ce_api
    
    * Updated vbms service spec
    
    * Updated manifest spec for uat expiration hours
    
    * send user feature toggle combined with use_ce_api
    
    * Combined with ce_api feature toggle
    
    * Update failing rspecs
    
    * Remove feature flag from method, wrapped method with all ce api calls
    
    * wrap ce_api related sensitivity changes
    
    * Fix failing specs, reverted to prior code outside of feature flag
    
    * update manifest expiry hours to not change in test + non prod
    
    * remove pry, reverted to previous test case
    
    * If user is blank, return
    
    * update front end error handling
    
    * Linting
    
    * Revert changes
    Kevma50287 authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    919352c View commit details
    Browse the repository at this point in the history
  26. typo fix (#1702)

    Kevma50287 authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    50d2d0c View commit details
    Browse the repository at this point in the history
  27. Kev ma/appeals 58827 v2 (#1703)

    * Change type_description to mapping
    
    * Updated rspecs to handle edge case
    Kevma50287 authored and youfoundmanesh committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    05044a2 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    6b58ecc View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    c31b56d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Deepak/appeals 59642 v1 (#1714)

    * pass user info to ceapi
    
    * Update specs
    
    * update branch name
    
    * fix rspec
    
    * update claim_evidence_request method
    
    * change ref to branch
    
    * revert x86
    
    ---------
    
    Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
    SanthiParakal133 and youfoundmanesh authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7f74f46 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    39c912d View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Improve Claim Evidence API Error Logging (#1723)

    * Add CE API Error Handler Class
    
    * Update VBMSService and SensitivityChecker Classes with Error Handling
    
    * Update VBMSService with CE API Error Handling
    
    * Fix Bad Method Signature
    
    * Fix More Spec Failures
    tradesmanhelix authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5d178d2 View commit details
    Browse the repository at this point in the history