APPEALS-24727 Removed unnecessary props and comments. Refactored retr…

…y button onclick
department-of-veterans-affairs · Aug 25, 2023 · 4595025 · 4595025
1 parent 1e03765
commit 4595025
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/client/app/queue/CreateMailTaskDialog.jsx b/client/app/queue/CreateMailTaskDialog.jsx
@@ -136,8 +136,6 @@ export class CreateMailTaskDialog extends React.Component {
             appealId={this.props.appealId}
             requestType={this.state.selectedValue}
             onChange={(value, valid) => this.setState({ eFolderUrl: value, eFolderUrlValid: valid })}
-            value={this.state.eFolderUrl}
-            valid={this.state.eFolderUrlValid}
           />
         }
         <TextareaField

diff --git a/client/app/queue/components/EfolderUrlField.jsx b/client/app/queue/components/EfolderUrlField.jsx
@@ -39,7 +39,6 @@ const EfolderUrlField = (props) => {
       then((response) => {
         if (response.body.document_presence === true) {
           apiValidity = true;
-          // setValid(true);
           setError('');
         } else {
           apiValidity = false;
@@ -49,7 +48,6 @@ const EfolderUrlField = (props) => {
       }).
       catch(() => {
         apiValidity = false;
-        // setValid(false);
         setError(COPY.EFOLDER_CONNECTION_ERROR);
       }).
       finally(() => {
@@ -79,6 +77,13 @@ const EfolderUrlField = (props) => {
     setValid(newValidity);
   }, 500);
 
+  const retryOnClick = async () => {
+    const retryValidity = await checkIfDocumentExists();
+
+    setValid(retryValidity);
+    props?.onChange?.(url, retryValidity);
+  };
+
   useEffect(() => {
     props?.onChange?.(url, false);
     handleDebounce(url);
@@ -101,7 +106,7 @@ const EfolderUrlField = (props) => {
     {
       error === COPY.EFOLDER_CONNECTION_ERROR &&
       <Button
-        onClick={() => checkIfDocumentExists()}
+        onClick={retryOnClick}
         linkStyling
         classNames={['cf-push-right', 'cf-retry']}>
           Retry
@@ -113,9 +118,7 @@ const EfolderUrlField = (props) => {
 EfolderUrlField.propTypes = {
   appealId: PropTypes.string.isRequired,
   requestType: PropTypes.string,
-  value: PropTypes.string,
-  errorMessage: PropTypes.string,
-  valid: PropTypes.bool
+  errorMessage: PropTypes.string
 };
 
 export default EfolderUrlField;