reduce method in the controller

department-of-veterans-affairs · Oct 25, 2024 · 7bf3c30 · 7bf3c30
1 parent 4539456
commit 7bf3c30
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/app/controllers/tasks_controller.rb b/app/controllers/tasks_controller.rb
@@ -187,7 +187,7 @@ def request_hearing_disposition_change
   end
 
   def upload_transcription_to_vbms
-    if task.type == "ReviewTranscriptTask" && task.status == "in_progress"
+    return unless task.type == "ReviewTranscriptTask" && task.status == "in_progress"
       new_instructions = task.instructions.push(params[:task][:instructions])
 
       Transcription.where(task_id: task.id).update_all(
@@ -201,7 +201,6 @@ def upload_transcription_to_vbms
         status: Constants.TASK_STATUSES.completed,
         closed_at: Time.zone.now
       )
-    end
   end
 
   private