Minor fixes

department-of-veterans-affairs · May 21, 2024 · 7d3b19c · 7d3b19c
1 parent aa5971e
commit 7d3b19c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/db/seeds/demo_ama_aod_hearing_data.rb b/db/seeds/demo_ama_aod_hearing_data.rb
@@ -46,7 +46,7 @@ def random_demo_file_number_and_participant_id
     end
 
     def find_or_create_demo_seed_judge(judge_ccs_id)
-      unless judge_ccs_id.empty?
+      unless judge_ccs_id.nil?
         User.find_by_css_id(judge_ccs_id) ||
           create(:user, :judge, :with_vacols_judge_record, css_id: judge_ccs_id, full_name: "Demo Judge " + judge_ccs_id)
       else

diff --git a/db/seeds/demo_ama_non_aod_hearing_data.rb b/db/seeds/demo_ama_non_aod_hearing_data.rb
@@ -45,7 +45,7 @@ def random_demo_file_number_and_participant_id
     end
 
     def find_or_create_demo_seed_judge(judge_ccs_id)
-      unless judge_ccs_id.empty?
+      unless judge_ccs_id.nil?
         User.find_by_css_id(judge_ccs_id) ||
           create(:user, :judge, :with_vacols_judge_record, css_id: judge_ccs_id, full_name: "Demo Judge " + judge_ccs_id)
       else

diff --git a/db/seeds/demo_direct_reviews_data.rb b/db/seeds/demo_direct_reviews_data.rb
@@ -21,6 +21,8 @@ def create_ama_direct_review
         :appeal,
         :direct_review_docket,
         :ready_for_distribution,
+        :tied_to_judge,
+        tied_judge: @associated_judge,
         associated_judge: @associated_judge,
         veteran: create_demo_veteran_for_docket,
         receipt_date: @days_ago
@@ -42,7 +44,7 @@ def random_demo_file_number_and_participant_id
     end
 
     def find_or_create_demo_seed_judge(judge_ccs_id)
-      unless judge_ccs_id.empty?
+      unless judge_ccs_id.nil?
         User.find_by_css_id(judge_ccs_id) ||
           create(:user, :judge, :with_vacols_judge_record, css_id: judge_ccs_id, full_name: "Demo Judge " + judge_ccs_id)
       else

diff --git a/db/seeds/demo_legacy_cases_data.rb b/db/seeds/demo_legacy_cases_data.rb
@@ -69,7 +69,7 @@ def random_demo_file_number_and_participant_id
     end
 
     def find_or_create_demo_seed_judge(judge_ccs_id)
-      unless judge_ccs_id.empty?
+      unless judge_ccs_id.nil?
         User.find_by_css_id(judge_ccs_id) ||
           create(:user, :judge, :with_vacols_judge_record, css_id: judge_ccs_id, full_name: "Demo Judge " + judge_ccs_id)
       else